Johannes Barop has posted comments on this change.
Change subject: Add History.getUrl(String token) which returns the
corresponding URL for a history token.
......................................................................
Patch Set 2:
The first alternative is HyperlinkImpl. But this would introduce spaghetti
inheritance because of the existing HyperlinkImpl's. And it clutters the
History stuff across multiple classes.
Other alternative: Add it only to HistoryImpl and let Hyperlink use
HistoryImpl directly. But this is not optimal because then we have to
duplicate the HistoryImpl.init() error handling and it feels hacky to me.
I think a new method to generate a link for a given history token is the
best way in the end because generating URLs is a part of implementing
History mechanisms.
This change makes the code of gwt-pushstate simpler. However I have already
a workaround for it. So it's not critical and we can take time to think
over it.
--
To view, visit https://gwt-review.googlesource.com/2960
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f9b261547b539489d9cee8a72f660264d64e9f2
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Johannes Barop <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Jens Nehlmeier <[email protected]>
Gerrit-Reviewer: Johannes Barop <[email protected]>
Gerrit-HasComments: No
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
