Stephen Haberman has posted comments on this change.
Change subject: Have SimpleCheckBox implement HasValue, fixes 4018.
......................................................................
Patch Set 1:
(2 comments)
....................................................
File user/src/com/google/gwt/user/client/ui/SimpleCheckBox.java
Line 230: if (value.equals(oldValue)) {
Yeah; this code is copy/pasted from CheckBox, and I had thought of using
fireIfNotEqual, but went back and forth on keeping it like CheckBox or not;
technically fireIfNotEqual does a few more operations (null checks) but it
won't matter.
I'll use fireIfNotEqual instead.
....................................................
File user/test/com/google/gwt/user/client/ui/SimpleCheckBoxTest.java
Line 92: cb.getElement().<ButtonElement> cast().click();
Would be fine with me; I admittedly copy/pasted this from one of your
Stackoverflow answers. :-)
--
To view, visit https://gwt-review.googlesource.com/3010
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I790120198cb22ff38e676a303782b719f87083c6
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Stephen Haberman <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Stephen Haberman <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
