Goktug Gokdogan has posted comments on this change.
Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
......................................................................
Patch Set 2:
(5 comments)
Looks good. Only a few style related comments...
....................................................
File user/src/com/google/gwt/dom/client/Element.java
Line 595: */
private static
Line 596: static String checkClassName(String className) {
I think it is better to name this method trimClassName and update the
javadoc accordingly.
Line 600: assert (className.length() != 0) : "Unexpectedly empty class
name";
assert !className.isEmpty()
Line 602: return className;
nit: can you remove extra spaces in this method
....................................................
File user/test/com/google/gwt/dom/client/ElementTest.java
Line 72: assertFalse(div.hasClassName("foo"));
Can you also add:
assertTrue(div.hasClassName("bar"));
--
To view, visit https://gwt-review.googlesource.com/3070
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia09567b8c58cac02f8126c33ef169b26def3d19c
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
