Brian Slesinsky has submitted this change and it was merged.
Change subject: Revert the automatic selection of sourceLevel.
......................................................................
Revert the automatic selection of sourceLevel.
There is a JDT bug (https://bugs.eclipse.org/bugs/show_bug.cgi?id=397462)
that only occurs when sourceLevel 7 that prevents the compilation
of code that is correct.
When that bug is fixed or patched in GWT we can revert.
Change-Id: I20b1e0206763179e6e8abcfe7ad4308487277e1d
---
M dev/core/src/com/google/gwt/dev/util/arg/SourceLevel.java
1 file changed, 6 insertions(+), 3 deletions(-)
Approvals:
Leeroy Jenkins: Verified
Brian Slesinsky: Looks good to me, approved
Goktug Gokdogan: Looks good to me, approved
diff --git a/dev/core/src/com/google/gwt/dev/util/arg/SourceLevel.java
b/dev/core/src/com/google/gwt/dev/util/arg/SourceLevel.java
index b2d5309..be8c8d5 100644
--- a/dev/core/src/com/google/gwt/dev/util/arg/SourceLevel.java
+++ b/dev/core/src/com/google/gwt/dev/util/arg/SourceLevel.java
@@ -15,8 +15,6 @@
*/
package com.google.gwt.dev.util.arg;
-import com.google.gwt.util.tools.Utility;
-
/**
* Java source level compatibility constants.
* Java versions range from 1.0 to 1.7.
@@ -62,6 +60,11 @@
static {
SourceLevel result = SourceLevel.values()[0];
+ /* TODO(rluble): source level should be set automatically to match the
java version
+ * but a JDT bug is preventing the change (some correct code does not
compile
+ * under sourceLevel 7).
+ * Uncomment the following code use the JDT is fixed or patched.
+
String javaSpecLevel =
System.getProperty("java.specification.version");
try {
for (SourceLevel sourceLevel : SourceLevel.values()) {
@@ -71,7 +74,7 @@
}
} catch (IllegalArgumentException e) {
}
-
+ */
DEFAULT_SOURCE_LEVEL = result;
}
--
To view, visit https://gwt-review.googlesource.com/3080
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I20b1e0206763179e6e8abcfe7ad4308487277e1d
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman <rlu...@google.com>
Gerrit-Reviewer: Brian Slesinsky <skybr...@google.com>
Gerrit-Reviewer: Goktug Gokdogan <gok...@google.com>
Gerrit-Reviewer: Leeroy Jenkins <jenk...@gwtproject.org>
Gerrit-Reviewer: Matthew Dempsky <mdemp...@google.com>
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
