On Friday, May 31, 2013 3:22:21 AM UTC+2, Goktug Gokdogan wrote: > > Hi folks. > > We currently have a coding style guide for GWT-SDK here: > https://developers.google.com/web-toolkit/makinggwtbetter#codestyle > The guide has some enforcements like static/non-static + alphabetical > ordering. Alphabetical ordering is as good as no ordering in many cases and > these rules are already broken in many places. > > I propose following Guava and many other java libs and just enforce > logical ordering during code reviews (which is also internal recommendation > at Google). One good approach for logical order is to group related public > APIs and then slot in other methods and nested-classes to keep them close > to the related context. This usually helps to follow the code with less > jumps around the class. > > Anyway, I know this can quickly turn into a bikeshed discussion so please > try to resist the urge to oppose unless you have a big concern =) >
We (the Steering Committee) decided to relax the ordering last year: https://docs.google.com/document/d/17kkpC0M_rj7azmKBZttYaDwUymOfyPwjurHCW6LF3hc/edit?usp=sharing and this was done in https://gwt-review.googlesource.com/1051 One of the rationale for the change is that changing the visibility of a field/method or turning a static method into a member method (or the other way around) meant moving the field/method in the file, which makes reviewing changes more difficult (when it's not only about changing the visibility but also a few changes within the method) So yes, the website needs to be updated. BTW, removal of the custom checkstyle rules makes it possibly/easier to update to a newer checkstyle version (people like having checkstyle run in their IDE, and our old version can no longer be installed in newer versions of Eclipse). If anyone wants to have a look at it, patches are always welcome. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
