Thomas Broyer has posted comments on this change.
Change subject: Removes delegation of event from TextBox event handler
inside SuggestBox.
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
....................................................
File user/test/com/google/gwt/user/client/ui/SuggestBoxTest.java
Line 375: public void testKeyDownEvent() {
Should we add a link to the issue in a comment here? or we think "git
blame" will be enough to find why we added these methods?
How about:
/*
* We used to have a keydown events fired twice.
* See https://code.google.com/p/google-web-toolkit/issues/detail?id=3533
*/
--
To view, visit https://gwt-review.googlesource.com/3141
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I70752f24667a83bee208f31f37ec63d79ec8b1b8
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Patrick Tucker <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
