Brian Slesinsky has submitted this change and it was merged.
Change subject: Revert "Update how columns are hidden in CellTable."
......................................................................
Revert "Update how columns are hidden in CellTable."
This reverts commit 94c3f2c58bb96cd26d210eadaf5fec5c8e30468e
Change-Id: I6df575d6d1f5e8b5ec5bef54d5ede7ad2dfca104
---
M user/src/com/google/gwt/user/cellview/client/CellTable.java
M user/test/com/google/gwt/user/cellview/client/CellTableTest.java
2 files changed, 5 insertions(+), 6 deletions(-)
Approvals:
Leeroy Jenkins: Verified
Goktug Gokdogan: Looks good to me, approved
diff --git a/user/src/com/google/gwt/user/cellview/client/CellTable.java
b/user/src/com/google/gwt/user/cellview/client/CellTable.java
index 355f960..12b3db2 100644
--- a/user/src/com/google/gwt/user/cellview/client/CellTable.java
+++ b/user/src/com/google/gwt/user/cellview/client/CellTable.java
@@ -824,11 +824,11 @@
// enabled), and refreshColumnWidth/clearColumnWidth. The latter two
are no op if setColumnWidth
// is not invoked first.
if (colGroupEnabled) {
- TableColElement columnElement = ensureTableColElement(column);
- columnElement.getStyle().setProperty("width", width == null ? "" :
width);
-
- boolean isColumnVisible = !"0".equals(width) && !"0px".equals(width);
- setVisible(columnElement, isColumnVisible);
+ if (width == null) {
+ ensureTableColElement(column).getStyle().clearWidth();
+ } else {
+ ensureTableColElement(column).getStyle().setProperty("width",
width);
+ }
}
}
diff --git
a/user/test/com/google/gwt/user/cellview/client/CellTableTest.java
b/user/test/com/google/gwt/user/cellview/client/CellTableTest.java
index e214e3d..c54266f 100644
--- a/user/test/com/google/gwt/user/cellview/client/CellTableTest.java
+++ b/user/test/com/google/gwt/user/cellview/client/CellTableTest.java
@@ -297,7 +297,6 @@
table.removeColumn(column1);
table.getPresenter().flush();
assertEquals("0px", col1.getStyle().getWidth());
- assertEquals("none", col1.getStyle().getDisplay());
}
@Override
--
To view, visit https://gwt-review.googlesource.com/3152
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6df575d6d1f5e8b5ec5bef54d5ede7ad2dfca104
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
