Manuel Carrasco Moñino has posted comments on this change.
Change subject: FileUpload: extending FocusWidget instead of Widget so as
it exposes many features which already are in the file-input element:
click(), focus(), mouseevents, keyevents, etc.
......................................................................
Patch Set 2:
(2 comments)
....................................................
File user/src/com/google/gwt/user/client/ui/FileUpload.java
Line 198: * Programmatic equivalent of the user clicking the button.
Yes, I'll update the javadoc to add a note with supported browsers.
Related with setVisible, isVisible, I have planned a different patch so as
we can use a different implementation per browser so as user has not to
worry about which hack use to hide the file input.
....................................................
File user/test/com/google/gwt/user/client/ui/ButtonTest.java
Line 39: // protected because it is used in FileUploadTest
They are in the same package, and does the same so just a way to not
duplicate code. I dont think a future change in the handler could break the
product since they are tests and the second test would fail, but if you
think it's better to duplicate, its ok.
--
To view, visit https://gwt-review.googlesource.com/3211
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4bc3c0991c5025a10a14b2f04ece6d91e11bcddb
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Manuel Carrasco Moñino <[email protected]>
Gerrit-Reviewer: Daniel Kurka <[email protected]>
Gerrit-Reviewer: Manuel Carrasco Moñino <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
