+mdempsky Hi, I think you're going to have more trouble than most because you're using Windows and that's not so common for GWT development. The code to automatically add the Change-Id line is specific to Unix but you can do it manually by editing the changelist yourself. To fix your most recent commit, run "git commit --amend" and cut and paste the Change-Id line from the error message to the end of the commit message.
(I believe each commit has to have its own Change-Id line and will be reviewed separately? Not sure how that works.) - Brian On Mon, Jun 10, 2013 at 8:17 AM, Patrick Tucker <[email protected]> wrote: > Well I just wasted another few hours this morning trying to figure out how > to commit something to this new system. > > Are these instructions complete?? > > Currently when I try to do a "git push" it tells me I have to provide a > Change-Id. I copied the hook file to the hooks folder and the message did > not go away. The command that GIT tells me to run executes chmod in it, > being that I am on a windows machine it obviously fails. The online help > page also tells me to execute the same command. > > I'm at a loss. > > On Monday, June 10, 2013 10:43:27 AM UTC-4, Patrick Tucker wrote: > >> Thanks for the quick response, but that doesn't answer my question. >> >> I realize foo is a place holder, I'm trying to figure out what it >> represents. A file, a message to the reviewers, ... I'm trying to figure >> out what I should replace it with. >> >> Thanks again, >> Pat >> >> >> On Mon, Jun 10, 2013 at 9:54 AM, Daniel Kurka <[email protected]>wrote: >> >>> Hi Patrick, >>> >>> foo is often used as a place holder, so something like: >>> git add foo >>> should mean: >>> git add my_cool_edited_file >>> >>> -Daniel >>> >>> >>> On Mon, Jun 10, 2013 at 3:35 PM, Patrick Tucker <[email protected]>wrote: >>> >>>> From the gwtproject "Making GWT Better" page section "Gerrit Setup" >>>> step 3: >>>> >>>>> Make a change and commit it locally using git (e.g., edit a file foo >>>>> and then run ?git commit -m ?my first change? foo?). >>>> >>>> >>>> What does foo represent? >>>> >>>> Thanks, >>>> Pat >>>> >>>> >>>> On Mon, May 20, 2013 at 3:18 PM, Thomas Broyer <[email protected]>wrote: >>>> >>>>> Should be >>>>> http://gwtproject.org/**makinggwtbetter.html<http://gwtproject.org/makinggwtbetter.html> >>>>> >>>>> On Sunday, May 19, 2013 10:00:01 PM UTC+2, Patrick Tucker wrote: >>>>>> >>>>>> I started from scratch and was able to get it mostly working. Is >>>>>> there a doc that explains the right way to submit a patch? >>>>>> >>>>>> On Friday, May 17, 2013 1:19:33 PM UTC-4, Patrick Tucker wrote: >>>>>>> >>>>>>> Windows 7 Pro >>>>>>> >>>>>>> On Friday, May 17, 2013 12:51:47 PM UTC-4, Matthew Dempsky wrote: >>>>>>> >>>>>>>> On Fri, May 17, 2013 at 9:45 AM, Patrick Tucker >>>>>>>> <[email protected]>wrote: >>>>>>>> >>>>>>>>> I'm not sure where to find the file that you are referring to, it >>>>>>>>> is not in my eclipse install folder? >>>>>>>>> >>>>>>>> >>>>>>>> John was referring to the "eclipse" directory in the GWT source >>>>>>>> code tree: https://gwt.**googlesource**.com/gwt/+/master/**eclipse/ >>>>>>>> **README.txt<https://gwt.googlesource.com/gwt/+/master/eclipse/README.txt> >>>>>>>> >>>>>>>> I was playing with the settings and tried removing one of the >>>>>>>>> source folders so that I could add it back and got an error saying >>>>>>>>> the file >>>>>>>>> system is read only. Any idea why it would do that? >>>>>>>>> >>>>>>>> >>>>>>>> Not sure, that sounds odd to me. Just out of curiosity, what OS >>>>>>>> are you using? >>>>>>>> >>>>>>>> >>>>>>>> When you prepared the patch from Rietveld, did you checkout the >>>>>>>> code from Subversion or use the 2.5.1 SDK release zip file? If you >>>>>>>> were >>>>>>>> already using Subversion, I would expect using Git shouldn't be any >>>>>>>> different to setup in Eclipse since the source tree should be the same. >>>>>>>> >>>>>>> >>>> -- >>>> http://groups.google.com/**group/Google-Web-Toolkit-**Contributors<http://groups.google.com/group/Google-Web-Toolkit-Contributors> >>>> --- >>>> You received this message because you are subscribed to the Google >>>> Groups "GWT Contributors" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to google-web-toolkit-**contributors+unsubscribe@** >>>> googlegroups.com<google-web-toolkit-contributors%[email protected]> >>>> . >>>> For more options, visit >>>> https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/opt_out> >>>> . >>>> >>>> >>>> >>> >>> >>> >>> -- >>> Google Germany GmbH >>> *Dienerstr. 12* >>> *80331 München* >>> >>> Registergericht und -nummer: Hamburg, HRB 86891 >>> Sitz der Gesellschaft: Hamburg >>> Geschäftsführer: Graham Law, Katherine Stephens >>> >>> -- >>> http://groups.google.com/**group/Google-Web-Toolkit-**Contributors<http://groups.google.com/group/Google-Web-Toolkit-Contributors> >>> --- >>> You received this message because you are subscribed to a topic in the >>> Google Groups "GWT Contributors" group. >>> To unsubscribe from this topic, visit https://groups.google.com/d/** >>> topic/google-web-toolkit-**contributors/hJzwtP-zEZw/** >>> unsubscribe?hl=en-US<https://groups.google.com/d/topic/google-web-toolkit-contributors/hJzwtP-zEZw/unsubscribe?hl=en-US> >>> . >>> To unsubscribe from this group and all its topics, send an email to >>> google-web-toolkit-**contributors+unsubscribe@**googlegroups.com<google-web-toolkit-contributors%[email protected]> >>> . >>> For more options, visit >>> https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/opt_out> >>> . >>> >>> >>> >> >> -- > http://groups.google.com/group/Google-Web-Toolkit-Contributors > --- > You received this message because you are subscribed to the Google Groups > "GWT Contributors" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/groups/opt_out. > > > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
