Stephen Haberman has posted comments on this change.
Change subject: Fix non-final field initializers running before the super
cstr.
......................................................................
Patch Set 9:
Huh. I knew this correct way was "slower" but I'm surprised it actually
showed up as a performance regression.
I agree looking for Object or super-cstrs with virtual calls is a good
approach for keeping the old behavior. I can play with those.
I'm more curious about what we should do now in master--revert this commit
there as well, with the idea that we can re-commit it when it has the
optimization in place?
Alternatively, we could leave it in master, and make a separate CL to add
the optimization, but then you guys will have to un-revert it for the
optimization-only CL to apply cleanly.
Seems cleaner to revert it from master for now?
--
To view, visit https://gwt-review.googlesource.com/3030
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c8ed0cd718a2188b33cc290fec6071c89be7918
Gerrit-PatchSet: 9
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Stephen Haberman <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Matthew Dempsky <[email protected]>
Gerrit-Reviewer: Ray Cromwell <[email protected]>
Gerrit-Reviewer: Roberto Lublinerman <[email protected]>
Gerrit-Reviewer: Stephen Haberman <[email protected]>
Gerrit-HasComments: No
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
