Goktug Gokdogan has posted comments on this change.
Change subject: Adds Timer#isRunning().
......................................................................
Patch Set 2:
(1 comment)
....................................................
File user/src/com/google/gwt/user/client/Timer.java
Line 151:
I think javadoc looks good right now:
"Returns {@code true} if the timer is running. Timer is running if and
only if it is scheduled but it is not expired or cancelled."
Actually it is more clear than java.swing.Timer's description which has the
same behavior =) :
"Returns true if the Timer is running."
If you have something specific in your mind then we can change it. However,
we should be careful when adding more data on the javadoc as developers
start thinking about if there is a special behavior and if they should be
doing something specific to handle that. In this case, they should not have
any concerns.
--
To view, visit https://gwt-review.googlesource.com/3321
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0133c64de75d5d95cff863c5ab950d474dda0c56
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Daniel Kurka <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
