Roberto Lublinerman has posted comments on this change.
Change subject: adds type tightening (and tests) for casts inside of
RunAsync onSuccessCalls, resulting in smaller leftover fragments
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Aside for the comment LGTM.
....................................................
File dev/core/src/com/google/gwt/dev/jjs/impl/TypeTightener.java
Line 631: return super.visit(x, ctx);
I would just return true that means that other children will be visited to
follow standard protocol.
Also add a comment before traverseOnSuccess mentioning that JRunAsync is
treated different than other ones and some of its child nodes are not
traversed normally and that it needs to be forced to traverse the onSuccess
call.
--
To view, visit https://gwt-review.googlesource.com/3460
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b454db222da054834aa0d78b1a769100bf9da9b
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: John Stalcup <stal...@google.com>
Gerrit-Reviewer: John Stalcup <stal...@google.com>
Gerrit-Reviewer: Leeroy Jenkins <jenk...@gwtproject.org>
Gerrit-Reviewer: Roberto Lublinerman <rlu...@google.com>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
