Manuel Carrasco Moñino has posted comments on this change.

Change subject: Adds Node#removeAllChildren.
......................................................................


Patch Set 1:

(2 comments)

....................................................
File user/src/com/google/gwt/dom/client/Node.java
Line 298:     while (this.lastChild) {
Doesn't innerHTML = "" perform better in HTML? I know it cannot be used with non html nodes though


Line 303:   /**
Agree, using java here would reuse jsni from other methods, taking advantage of gwtc optimizations.


--
To view, visit https://gwt-review.googlesource.com/3511
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic607bf6523a41c0ee4020a12e8505b1d8b39d916
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Daniel Kurka <[email protected]>
Gerrit-Reviewer: Manuel Carrasco Moñino <[email protected]>
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to