Matthew Dempsky has posted comments on this change.

Change subject: Add a FakeSafeHtmlTemplatesMaker to complement FakeMessagesMaker and FakeCssMaker, allowing Java tests to create instances of these without GWT.create().
......................................................................


Patch Set 2:

(2 comments)

....................................................
Commit Message
Line 7: Add a FakeSafeHtmlTemplatesMaker to complement FakeMessagesMaker and FakeCssMaker, allowing Java tests to create instances of these without GWT.create().
Thanks.  I'd reformat this as:

    Add FakeSafeHtmlTemplatesMaker

    Similar to FakeMessageMaker and FakeCssMaker, this class allows Java
    tests to create instances of SafeHtmlTemplates without needing to call
    GWT.create().

    Change-Id: Ic30bd738a9e931d1f207ee3a86eabe52cbee7161

because Git wants the first paragraph of a commit message to be a single line less than about 70 characters, and for the rest of the commit message to be wrapped at about 80 characters.


....................................................
File user/test/com/google/gwt/junit/FakeSafeHtmlTemplatesMakerTest.java
Line 27: public class FakeSafeHtmlTemplatesMakerTest extends TestCase {
I think you'll need to hook this into JUnitSuite for it to actually run?


--
To view, visit https://gwt-review.googlesource.com/3580
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic30bd738a9e931d1f207ee3a86eabe52cbee7161
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Jason Heim <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Matthew Dempsky <[email protected]>
Gerrit-HasComments: Yes

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to