John Stalcup has posted comments on this change.
Change subject: Super Dev Mode: deemphasize unused Java lines in
codeserver's UI
......................................................................
Patch Set 1:
(6 comments)
most of these comments are just suggestions.
....................................................
File dev/codeserver/java/com/google/gwt/dev/codeserver/ReverseSourceMap.java
Line 12: private final SourceMapConsumerV3 consumer;
i think "consumer" is too vague
Line 20: * If it can't be loaded, logs an error and returns null.
"logs a warning"
Line 29: logger.log(TreeLogger.WARN, "can't parse source map", e);
seems like maybe the decision about whether a parse exception is fatal,
should be deferred to the caller of load() not to load() itself?
....................................................
File dev/codeserver/java/com/google/gwt/dev/codeserver/SourceHandler.java
Line 189: private void sendSourceFileAsHtml(String moduleName, String
fileName, BufferedReader lines,
is source html highlighting out of scope for the responsibilities of this
file? "Serves Java source files so that a browser's debugger can display
them."
Line 194: File file = new File(fileName);
s/fileName/sourceFileName
s/file/sourceFile
Line 200: out.startTag("html").nl();
it might not be worth the hassle, but did you consider using some sort of
string templating library instead?
--
To view, visit https://gwt-review.googlesource.com/3600
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id16bcd2287630cebf7afb8bbbe0a198b28f5ada9
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: John Stalcup <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Matthew Dempsky <[email protected]>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
