Thomas Broyer has posted comments on this change.
Change subject: Making DialogBox clear handlers on auto hide
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
....................................................
File user/src/com/google/gwt/user/client/ui/DialogBox.java
Line 305: if (resizeHandlerRegistration != null) {
super.hide() calls hide(false), so the hide() override can safely be
removed (and we can either make it clear in the hide() javadoc that it's
equivalent to hide(false), and/or add tests that resizeHandlerRegistration
is null after calls to both hide() and hide(boolean).
--
To view, visit https://gwt-review.googlesource.com/3612
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa4c76643eecf1b51820861f193de36ed44e9f41
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
