Thomas Broyer has posted comments on this change.
Change subject: Add wrap method to Canvas
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
....................................................
File user/src/com/google/gwt/canvas/client/Canvas.java
Line 55: public Canvas wrap(CanvasElement element) {
Missing 'static' modifier.
Should it be named wrapIfSupported?
We should also add javadoc to make the 'return null' case explicit (like in
createIfSupported)
Line 56: if (!isSupported()) {
We should probably copy the algorithm from createIfSupported and
isSupported to pass 'element' to detector.isSupportedRunTime.
--
To view, visit https://gwt-review.googlesource.com/3613
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieca5c14e41b495da75004fa080409fca1b21b3d5
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
