Thomas Broyer has posted comments on this change.
Change subject: changes for 5113
......................................................................
Patch Set 1:
(1 comment)
....................................................
File user/src/com/google/gwt/i18n/tools/I18NCreator.java
Line 140: boolean isWindows =
System.getProperty("os.name").toLowerCase().indexOf("windows") >= 0;
Always pass Locale.ROOT or Locale.ENGLISH to toLowerCase if you don't want
to deal with angry Turkish users later ;-)
You can also use contains() instead of indexOf()>=0
--
To view, visit https://gwt-review.googlesource.com/3620
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2459dec8e68427f4b5051e2a3fdbb202291ccc92
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Chirag Vithlani <chirag.vithl...@gmail.com>
Gerrit-Reviewer: Daniel Kurka <danku...@google.com>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
