Thomas Broyer has posted comments on this change.
Change subject: Fix os detection in I18NCreater.I18NCreater failed to
detect windows properly.Fixes issue 5113.
......................................................................
Patch Set 1:
You should have amended your previous commit, not add a new one.
Please squash your 2 commits together into a single one:
git rebase -i HEAD^^
In the editor that opens, replace "pick" on the second line with "squash",
then save and exit.
In the next editor that opens, copy/paste the following lines:
Fix os detection in I18NCreator.
I18NCreator failed to detect windows properly.
Bug: issue 5113
Change-Id: I2459dec8e68427f4b5051e2a3fdbb202291ccc92
(it's the Change-Id of the first commit, to associate with the correct
review in Gerrit, and the commit message from the second commit, slightly
enhanced)
Check in "git log" or "gitk" that you have a single commit with the correct
Change-Id, then "git push origin HEAD:refs/for/master" to push it for
review. This should update the previous review with a new "patch set".
Finally, "abandon" that second review.
Tell us if you have issues following this procedure.
--
To view, visit https://gwt-review.googlesource.com/3621
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c943b328c050ec01e3717ce70280e647d5b4b7d
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Chirag Vithlani <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: No
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
