Manuel Carrasco Moñino has posted comments on this change.
Change subject: Fix binary vs. internal variable names, remove unused Name
code.
......................................................................
Patch Set 1:
(2 comments)
....................................................
File dev/core/src/com/google/gwt/dev/javac/JsniChecker.java
Line 85: * @param typeName Either source or binary names are allowed
in JSNI
I think you should change typeName by sourceOrBinaryName in the javadoc as
well.
....................................................
File dev/core/src/com/google/gwt/dev/util/Name.java
Line 42
Have you considered if these deletions could break anything?. They dont
break anyhing in gwt, but since they are public stuff, maybe 3party
libraries could be using them.
--
To view, visit https://gwt-review.googlesource.com/3470
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I540b1225efe7f81f0fc3ac50871cc66d1e99e753
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Stephen Haberman <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Manuel Carrasco Moñino <[email protected]>
Gerrit-Reviewer: Roberto Lublinerman <[email protected]>
Gerrit-Reviewer: Stephen Haberman <[email protected]>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
