Daniel Kurka has posted comments on this change.
Change subject: Log warning when wrongly using RootPanel
......................................................................
Patch Set 1:
(2 comments)
I think we should go with adding a comment to add (since all other adds
calls this one anyway)
I do not think we should override all add methods for this.
I do not think that adding a check to onAttach would be a good thing
either, there might be cases where we want to add LayoutPanels to other
containers.
This is just intended to highlight the most common error.
....................................................
File user/src/com/google/gwt/user/client/ui/RootPanel.java
Line 309: if (w instanceof LayoutPanel) {
RequiresResize would yield false positive (e.g. ScrollPanel)
Line 310: GWT.log("Adding a LayoutPanel to RootPanel, did you mean
RootLayoutPanel instead?");
I can't think of a valid case of adding LayoutPanels to a RootPanel instead
of RootLayoutPanel, so I do not think there is a need to turn the warning
off.
--
To view, visit https://gwt-review.googlesource.com/3637
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3b8a559edef046b4c2e9ad3e5ac5840a193428f
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka <[email protected]>
Gerrit-Reviewer: Daniel Kurka <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
