Thomas Broyer has posted comments on this change.
Change subject: Move arrow key functions from Tree to KeyCodes
......................................................................
Patch Set 1:
(4 comments)
....................................................
File user/src/com/google/gwt/event/dom/client/KeyCodes.java
Line 19: import com.google.gwt.i18n.client.LocaleInfo;
I don't quite like adding a dependency from c.g.g.dom on c.g.g.i18n; could
we instead add a 'boolean isRtl' argument to
maybeSwapArrowKeysBasedOnLocale?
Line 448: case KeyCodes.KEY_DOWN:
No need to qualify the constants with "KeyCodes." I guess.
Line 461: public static int maybeSwapArrowKeysbasedOnLocale(int code) {
Capital "B" for "BasedOnLocale"
This method should probably also be used in MenuBar, CellTree and
CellBrowser (and possibly AbstractCellTable)
....................................................
File user/src/com/google/gwt/user/client/ui/Tree.java
Line 167
+1 to removing those old compat workarounds.
--
To view, visit https://gwt-review.googlesource.com/3662
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I811520d330c181958dd67cbfbe30c46becebbe43
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
