Ray Cromwell has uploaded a new change for review.

  https://gwt-review.googlesource.com/3670


Change subject: Makes some private implementation classes of StackTraceCreator public to enable custom implementations. Useful for other Javascript VMs, as well as integration with non-GWT code, for example, stack traces which consist of GWT and Closure code.
......................................................................

Makes some private implementation classes of StackTraceCreator public
to enable custom implementations. Useful for other Javascript VMs,
as well as integration with non-GWT code, for example, stack traces
which consist of GWT and Closure code.

Change-Id: If5d481f6f566f3752a652aeb5140686b98af53b3
---
M user/src/com/google/gwt/core/client/impl/StackTraceCreator.java
1 file changed, 8 insertions(+), 7 deletions(-)



diff --git a/user/src/com/google/gwt/core/client/impl/StackTraceCreator.java b/user/src/com/google/gwt/core/client/impl/StackTraceCreator.java
index 8d804b1..95f72b9 100644
--- a/user/src/com/google/gwt/core/client/impl/StackTraceCreator.java
+++ b/user/src/com/google/gwt/core/client/impl/StackTraceCreator.java
@@ -35,14 +35,14 @@
   /**
    * Replacement for function names that cannot be extracted from a stack.
    */
-  private static final String ANONYMOUS = "anonymous";
+  public static final String ANONYMOUS = "anonymous";

   /**
    * This class acts as a deferred-binding hook point to allow more optimal
    * versions to be substituted. This base version simply crawls
    * <code>arguments.callee.caller</code>.
    */
-  static class Collector {
+  public static class Collector {
     public native JsArrayString collect() /*-{
       var seen = {};
       var toReturn = [];
@@ -226,7 +226,7 @@
   /**
    * Mozilla provides a <code>stack</code> property in thrown objects.
    */
-  static class CollectorMoz extends Collector {
+  public static class CollectorMoz extends Collector {
     /**
      * This implementation doesn't suffer from the limitations of crawling
* <code>caller</code> since Mozilla provides proper activation records.
@@ -269,7 +269,7 @@
    * at Type.functionName [as methodName] (file.js:1:2)
    * </pre>
    */
-  static class CollectorChrome extends CollectorMoz {
+  public static class CollectorChrome extends CollectorMoz {

     static {
       increaseChromeStackTraceLimit();
@@ -414,12 +414,13 @@
    */
   static class CollectorChromeNoSourceMap extends CollectorChrome {
     protected int replaceIfNoSourceMap(int line) {
-      return -1;
+      return LINE_NUMBER_UNKNOWN;
     }
   }

-  private static native int parseInt(String number) /*-{
-    return parseInt(number) || -1;
+  public static native int parseInt(String number) /*-{
+    return parseInt(number)
+ || @com.google.gwt.core.client.impl.StackTraceCreator::LINE_NUMBER_UNKNOWN;
   }-*/;

   /**

--
To view, visit https://gwt-review.googlesource.com/3670
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If5d481f6f566f3752a652aeb5140686b98af53b3
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Ray Cromwell <[email protected]>

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to