Goktug Gokdogan has posted comments on this change.
Change subject: Fixes Exception wrapping/unwrapping in compiler
......................................................................
Patch Set 3:
Actually, I briefly discussed this issue with you before when I asked you
putting try/catch block does any harm to javascript exceptions.
In GWT-SDK, there are places that avoid putting try/catch blocks like
Impl#entry, AsyncFragmentLoader etc. because doing so would -in the
original authors words- 'molest' the exception. After asking what was going
on, I verified that we always wrap javascript exceptions on any try/catch
block and never revert it back. So following code is destructive:
try {
// do something
} catch (Throwable t) {
throw t;
}
Most obvious artifact is, the browser will not show a proper stacktrace for
the exceptions that escaped from event loop. This change fixes this problem
by unwrapping the javascript exception upon throw. By this way, we can
simplify code that tries avoiding try/catch and make the intended solution
really work as it will also fix the problem completely as the try/catch
block might have been introduced by user code.
(I remember putting a long description to commit message that explains this
situation, apparently it didn't make it to the patch :( )
--
To view, visit https://gwt-review.googlesource.com/3601
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I419204b3b6f76bd9171c322a87fa164a7c72ab94
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Ray Cromwell <[email protected]>
Gerrit-Reviewer: Roberto Lublinerman <[email protected]>
Gerrit-HasComments: No
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
