I ported the CR to gerrit a couple of months back https://gwt-review.googlesource.com/#/c/3186/
Last update I got was that it's pending further review by Thomas Broyer who's currently tied up with modularization and mavenization. I'm seeing other RF changes going on though so hopefully it won't require too much reworking of my original commit. <rant> I totally understand there are limited resources for reviewing this stuff but it would be quite frustrating if many changes were necessary to my patch due to underlying changes. I submitted the patch over a year ago and it's the 6th highest starred issue on the issue tracker from what I can tell. </rant> On 29 July 2013 16:27, <[email protected]> wrote: > On 2012/10/30 08:28:07, james.horsley wrote: > >> On 2012/06/08 17:20:06, rdayal wrote: >> > Yep, you're on the CLA list. >> > >> > On Fri Jun 08 05:15:45 GMT-400 2012, James Horsley >> <mailto:james.horsley@gmail.**com <[email protected]>> >> > wrote: >> > >> > > Just to check, was everything okay with the CLA I signed? >> > > >> > > On 7 June 2012 16:56, James Horsley >> > <mailto:james.horsley@gmail.**com <[email protected]>> wrote: > >> > > >> > > Thanks Rajeev. Let me know if there's anything else you need with >> > it. > >> > > >> > > >> > > On 7 June 2012 16:18, Rajeev Dayal <mailto:[email protected]> >> > wrote: > >> > > >> > > Thomas, thanks for jumping in. >> > > >> > > James, as Thomas said, we'll defer this to 2.5.1, but we'd >> > definitely like > >> > > to get it in there, as it's an important patch. We just didn't >> > want to > >> > > force this patch in 2.5.0, which is what we would have to do with >> > the > >> > > current workload. >> > > >> > > Thanks so much for working on this. >> > > >> > > >> > > On Thu Jun 07 06:23:58 GMT-400 2012, >> > <mailto:james.horsley@gmail.**com <[email protected]>> wrote: > >> > > >> > > Totally agree on this needing another round. Also, hearing about >> > the > >> > > plans for a 2.5.1 release which this could potentially be a >> > candidate > >> > > for is great. >> > > >> > > Thanks again. >> > > >> > > On 2012/06/07 09:56:52, t.broyer wrote: >> > > > On 2012/06/07 09:22:24, james.horsley wrote: >> > > > > Thanks for all your help with the patch Thomas. Sad to hear it >> > won't > >> > > make it >> > > > > into GWT 2.5 as we were really looking to use RF with Maps >> > without > >> > > having to >> > > > use >> > > > > a patched version of GWT built from source internally. >> > > >> > > > We're planning a 2.5.1 soon after 2.5. >> > > > There are also several issues with Map support in AutoBeans >> > (reported > >> > > only >> > > > recently) which I'd like to get fixed at the same time (some of >> > them > >> > > are related >> > > > to how maps are encoded/decoded, so I'd like to have it the same >> > in > >> > > both >> > > > AutoBeans and RF; see >> > > > >> > http://code.google.com/p/**google-web-toolkit/issues/**detail?id=7395<http://code.google.com/p/google-web-toolkit/issues/detail?id=7395>for > >> > > instance, >> > > > which you seem to have avoided by using a slightly different >> > > serialization path >> > > > for keys, where String keys are encoded as "\"foo\"", vs. "foo" >> > in > >> > > AutoBean's >> > > > serialization). >> > > > Finally, to be honest, I think we need at least one more round >> > here: I > >> > > need some >> > > > more time to wrap my head around it. >> > > >> > > >> > > >> > > >> > >> > > http://codereview.appspot.com/**6132056/%253Chttps://www.** > google.com/url?sa=D&q=http://**codereview.appspot.com/**6132056/<http://codereview.appspot.com/6132056/%253Chttps://www.google.com/url?sa=D&q=http://codereview.appspot.com/6132056/> > > > >> > > >> > > >> > > >> > > >> > > I'm possibly being a bit eager given 2.5 GA only just went out but >> > thought I'd > >> just ping on this with regards to the 2.5.1 release that had been >> > mentioned. > > Anything new on this? > > https://codereview.appspot.**com/6132056/<https://codereview.appspot.com/6132056/> > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
