Actually this can be done without any changes to the java code (just some changes to the pom.xml), but if we allow images we should allow all other resources in the same folder structure, otherwise this will be even more confusing.
I don't really feel strongly here, any other opinions? On Fri, Sep 6, 2013 at 12:20 AM, Brandon Donnelson <[email protected]>wrote: > I think the main advantage I'm looking at is when writing the docs I find > it far easier to write when the images are relative to the markdown. > > I like to use the IDE to write the markdown, and having the images > relative to the markdown means the IDE can display the images in a live > preview and another instance is when pulling at least with github, could be > previewed as well. In this case github isn't as important. > > I can see the end results in a relative path when the site is rendered > with the maven plugin, in the target directory. You're right moving images > muddies the waters somewhat next to the markdown, although I think the > complexity is a bit less than having the images get thrown into the > src/main/site/images, at least I think its harder to track the images > folders when they don't exist next to the owner. I think another benefit to > having individual containers is, when screenshots have to be udpated, its > easier to find and manage the image update. > > While I think it makes sense for most sites to stick the images in there > own site folder because of redundancy I find with docs and guides usually > stand on there own and don't see a high number of repetition. One other > thought, a maven approach was mentioned, would it be more appropriate to > move the resources, markdown, into src/main/resources folder? My thought > about the maven approach, either location of the images seems to fit the > bill just fine. :) > > Overall, I think what gwt-site has now, works fine, although I thought it > might be handy to move the images. :) > > Brandon > > > > > On Thursday, September 5, 2013 11:10:14 AM UTC-7, Daniel Kurka wrote: > >> Hi Brandon, >> >> the markdown already supports relative urls for images and all other >> resources. However right now all resources except the markdown are kept in >> src/main/site while the markdown is located in src/main/markdown. >> >> I am open for discussing that we might want to change that and if that >> gives us any benefits, but it would definitely go away from the standard >> maven approach. Right now its easy to separate between markdown and >> structural files and all other resources. This would get harder going >> forward. >> >> >> >> > Whats this give me? >> > - This would allow for for relative path links to the images in the >> markdown, which allows for easier editing in any IDE with markdown editor. >> >> relative links already work, so is this advantage gone? >> >> > - In my opinion, easier tracking of resources through multiple >> versions. >> >> Why is that? >> >> >> >> >> >> >> >> >> On Wed, Sep 4, 2013 at 11:57 PM, Brandon Donnelson >> <[email protected]>wrote: >> >>> Daniel and team, >>> >>> Would you be interested in a patch that would allow for relative image >>> folders for the markdown files? >>> >>> What do you mean by relative image folders? >>> - Relative image folders or folders that start with "images*" would sit >>> in the gwt-site markdown directory, realtive to the mardown, and when the >>> site is rendered would be moved to the relative location to which the >>> markup is generated. >>> >>> Whats this give me? >>> - This would allow for for relative path links to the images in the >>> markdown, which allows for easier editing in any IDE with markdown editor. >>> - In my opinion, easier tracking of resources through multiple versions. >>> >>> Whats the code modification cost to gwt-site? >>> - The adjustments to code are minimal, which starts in the >>> FileTransversal and writes moves the files in the markup writer. >>> >>> Whats it look like in Eclipse? >>> - I've attached some screen shots. >>> >>> Would you be interested in the feature (/patch)? >>> >>> You can see we liked your configuration so much we adopted it to render >>> some markdown. :) >>> Brandon >>> >>> -- >>> http://groups.google.com/**group/Google-Web-Toolkit-**Contributors<http://groups.google.com/group/Google-Web-Toolkit-Contributors> >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "GWT Contributors" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to google-web-toolkit-**contributors+unsubscribe@** >>> googlegroups.com. >>> For more options, visit >>> https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/opt_out> >>> . >>> >> >> >> >> -- >> Google Germany GmbH >> *Dienerstr. 12* >> *80331 München* >> >> Registergericht und -nummer: Hamburg, HRB 86891 >> Sitz der Gesellschaft: Hamburg >> Geschäftsführer: Graham Law, Katherine Stephens >> > -- > http://groups.google.com/group/Google-Web-Toolkit-Contributors > --- > You received this message because you are subscribed to the Google Groups > "GWT Contributors" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/groups/opt_out. > -- Google Germany GmbH *Dienerstr. 12* *80331 München* Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Katherine Stephens -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
