Today, I was able to get Eclipse building the trunk with the latest Checkstyle v5.7 from http://eclipse-cs.sourceforge.net/update
I was seeing a ton (1200-1900+) of OrderCheck and FieldCheck errors using Checkstyle 4.2 or 4.3 in Eclipse. But with 5.7, I am not seeing any errors. It does appear that Checkstyle 4.2 is still being used by Ant though. There was some discussion about upgrading Checkstyle last year here <https://groups.google.com/forum/#!searchin/google-web-toolkit-contributors/checkstyle/google-web-toolkit-contributors/0aqmDB2tHfI/ZZTLRdinx-sJ> . *Checkstyle 5.7 includes Java 7 grammar support, which is now supported (and the default) in gwt 2.6.0+.* *In order to upgrade the current .xml configuration files for Checkstyle, the following appear to be needed:* *PackageHtml* looks like it can just be changed to *JavadocPackage*. *GenericIllegalRegexp* looks like it can just be changed to *RegexpSingleline*. It needs to be pulled out of the TreeWalker module. *TabCharacter* needs to be replaced with *FileTabCharacter*. It needs to be pulled out of the TreeWalker module and have the following added to it: <property name="fileExtensions" value="java"/> *RegexpHeader* needs to be pulled out of the TreeWalker module and have the following added to it: <property name="fileExtensions" value="java"/> There seems to be a bug with *SuppressionCommentFilter* and the use of messageFormat AND checkFormat not properly working together. Removing messageFormat seems to help for now. There is an issue about this here <https://github.com/checkstyle/checkstyle/issues/123>. There are 4 files in gwt-user that break the *AvoidStarImport* check which will need to be fixed. >From the checkstyle release notes: "Removed the DoubleCheckedLocking check, as in Java 5 (and beyond), using the volatile keyword addresses the issue. See here <http://jeremymanson.blogspot.com.au/2008/05/double-checked-locking.html> for more details." *Can this check be removed for gwt as well?* It looks like checkstyle-5.7-all.jar is already in gwt/tools/antlib/. So this would just mean a small change to trunk/common.ant.xml in addition to the configuration mentioned above. -- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/dc4df58a-3381-4daf-961a-3e820fea50c5%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
