On Saturday, June 14, 2014 9:51:13 PM UTC+2, Jens wrote: > > I'm not sure why or when that happened. I checked in a big patch (#7600) >> recently that may or may not have caused it. I wonder if someone can seek >> back before my commit and see if the failure is still present. >> > > Its not your commit that caused these errors. > > The RequestFactory error simply exists because no one seems to keep > requestfactory-apt.jar up-to-date in the SVN tools repo. Maybe the build > script can be updated to first build requestfactory-apt.jar and then use > this build version in other tasks. That way we don't need to > have requestfactory-apt.jar in the SVN repo. >
Just pushed https://gwt-review.googlesource.com/7855 which should fix this. > The other error has been introduced in > https://gwt-review.googlesource.com/#/c/7865/ . Prior to this CL there > wasn't any super source folder present in /user/test so ant script and the > eclipse .classpath file did not exclude **/super/**. > The gwt.javac macro in common.ant.xml excludes **/super/** by default, but the call point in compile.tests in user/build.xml overrides the excludes="" and removed the **/super/** exclusion. I think that was a bug (by oversight). Also note that user/BUILD already excluded **/super/** from user-test-code. > However I am wondering if the super source files in #7865 are better > placed into user/test-super ? I guess thats why test-super exists (?) > There's no strict rule. com.google.gwt.regexp.super is in user/src, not user/test for instance. I think the super/ root was originally more about IDEs than a real will to segregate those files. -- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/cf2a5f35-e19c-4ae1-922c-01dd1c64a07d%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
