On Tue, Oct 21, 2014 at 4:10 PM, David <[email protected]> wrote:

>
> On Mon, Oct 20, 2014 at 11:47 AM, Thomas Broyer <[email protected]>
> wrote:
>
>>
>> and you need to follow the steps very carefully (and hopefully no
>>> dependency has been changed since the document was written).
>>>
>>
>> I'm curious, which dependencies are you talking about?
>>
>
> In my case it was the checkstyle plugin for eclipse that was not
> compatible with a newer eclipse version. But I gave up shortly afterwards.
>

Ah yes. But nobody forces you to run Checkstyle in the IDE (I don't; when I
tried it some years ago it slowed Eclipse down to being almost unusable).
Maybe we should make things clearer in the doc that it's just a tool and
what matters is that the code is compliant with the style guides, not how
you make sure it's compliant ("ant checkstyle" works too; in my case, I
must confess I don't even run checkstyle on my machine because the rules
are common-sense to me and I rarely violate them – and if I do, then the
checks in Gerrit/Jenkins will slap me in the face)

(note: we since removed our custom checkstyle checks which freed us from
Checkstyle 4.x and have thus been able to upgrade to Checkstyle 5.x)


-- 
Thomas Broyer
/tɔ.ma.bʁwa.je/ <http://xn--nna.ma.xn--bwa-xxb.je/>

-- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAEayHEOuz9Wcv9W5noDGOFujCk9fYdcLH1UeTG8L30J_jms_Bg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to