Sorry for my late reply. I'm OK to not remove the code of the old css completely. I will propose another patch for that.
> That will the make the upgrade unnecessarily harder I just want to mention that the upgrade can be "hard" because UiBinder's inner style will use GSS by default. And the only way to deactivate that will be to add the attributes gss="false" on each inner style that are not compatible with GSS. Julien On Mon, Feb 23, 2015 at 11:20 PM 'Goktug Gokdogan' via GWT Contributors < [email protected]> wrote: > If we remove old css completely, that means we will force auto-conversion > by the time of upgrade to 2.8. That will the make the upgrade > unnecessarily harder (vs. upgrading 2.8 and choosing the time to the > conversion if necessary). Besides, if they haven't upgraded and using > auto-conversion, that is still not forcing migration, just leaves them with > not-as-well-tested support of old css. > Given that this is not buying as much, following the original plan to > provide a clean transition version looks better to me at the moment. We > can remove it all together after the 2.8 release. > > On Mon, Feb 23, 2015 at 10:18 AM, Jens <[email protected]> wrote: > >> I started migration today on a 300 KLOC project and all CSS files had >> been converted without any major issue using the Css2Gss tool. The only >> exotic issue I had was a NullPointerException for *.css files that do not >> have any content: >> https://code.google.com/p/google-web-toolkit/issues/detail?id=9131 >> >> After conversion I was a bit annoyed updating all the @Source annotations >> still pointing to *.css files. You can't blindly run a global string >> replace of .css -> .gss so this took some time. >> Also I did not add any gss=true attributes to UiBinder files because we >> simply have a lot of them and I don't want to do that work. I assume that >> this attribute is not needed anymore anyways once the GssResourceGenerator >> is enabled by default for UiBinder <ui:style> elements. >> >> Currently we run the app with CssResource.enableGss = true and >> CssResource.conversionMode >> = strict and do not have any issues. Overall it took less than an hour >> to achieve that state. >> >> >> So I think I would prefer the second option (delete the property and make >> GSS the default everywhere) but it would be nice if GWT would prefer a >> matching *.gss file for any *.css file referenced in @Source annotations >> (may the css file exist or not on disk) and print a warning in which >> ClientBundles that occurred. That way people could execute the Css2Gss tool >> and can start using 2.8. Deleting css files and cleaning up @Source >> annotations can then be done afterwards in smaller steps. >> >> >> -- J. >> >> -- >> You received this message because you are subscribed to the Google Groups >> "GWT Contributors" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/google-web-toolkit-contributors/8efa270c-e7fa-4337-9e46-60d25e393e05%40googlegroups.com >> <https://groups.google.com/d/msgid/google-web-toolkit-contributors/8efa270c-e7fa-4337-9e46-60d25e393e05%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> >> For more options, visit https://groups.google.com/d/optout. >> > > -- > You received this message because you are subscribed to the Google Groups > "GWT Contributors" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAN%3DyUA04acEEqBEP5LRO0qfdxGnXFS6GJEOtuEVAwYjv%3DZUr3w%40mail.gmail.com > <https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAN%3DyUA04acEEqBEP5LRO0qfdxGnXFS6GJEOtuEVAwYjv%3DZUr3w%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/CABb_3%3D4Ab2gNROSwwO7%2Bm1N%2B%3Dxmm-gx3NjR7LJLYGeY%3DxbsdtQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
