I have incorporated the latest review feedback and reposted. Please review again.
Thank you all for your patience as I learn the ropes... On Tuesday, March 22, 2016 at 2:51:05 PM UTC-7, David Becker wrote: > > Hi Jens, et. al, > > I was just wondering if you thought > https://gwt-review.googlesource.com/#/c/14300/ might get picked up in > time for 2.8? It seems to have stalled out on the review front. > > Thanks! > > On Thursday, January 28, 2016 at 3:55:34 PM UTC-8, Brandon Donnelson wrote: >> >> Thanks Jens, >> Brandon >> >> On Thu, Jan 28, 2016 at 3:52 PM, Jens <[email protected]> wrote: >> >>> Make both lines the same: >>> >>> >>> https://gwt.googlesource.com/gwt/+/master/dev/core/src/com/google/gwt/dev/DevModeBase.java#156 >>> >>> https://gwt.googlesource.com/gwt/+/master/dev/codeserver/java/com/google/gwt/dev/codeserver/Options.java#529 >>> >>> One uses getHostName() while the other uses getHostAddress() >>> >>> -- J. >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "GWT Contributors" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected] >>> . >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/google-web-toolkit-contributors/45e5da4d-6895-4174-8205-fd71040dd127%40googlegroups.com >>> >>> <https://groups.google.com/d/msgid/google-web-toolkit-contributors/45e5da4d-6895-4174-8205-fd71040dd127%40googlegroups.com?utm_medium=email&utm_source=footer> >>> . >>> >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> >> >> -- >> Regards, >> *Brandon Donnelson* >> GXT Support Engineer >> Office: +1-650-243-0623 >> >> [image: Sencha Inc.] <https://www.sencha.com/> >> >> [image: http://cdn.sencha.com/img/2016-email-sig/icon-facebook-24x24.png] >> <http://www.facebook.com/senchainc> >> >> [image: http://cdn.sencha.com/img/2016-email-sig/icon-twitter-24x24.png] >> <http://twitter.com/sencha> >> >> [image: http://cdn.sencha.com/img/2016-email-sig/icon-linkedin-24x24.png] >> <https://www.linkedin.com/company/sencha-inc> >> >> [image: http://cdn.sencha.com/img/2016-email-sig/icon-youtube-24x24.png] >> <http://www.youtube.com/SenchaInc> >> >> [image: >> http://cdn.sencha.com/img/2016-email-sig/icon-googleplus-24x24.png] >> <https://plus.google.com/117303203295549187007?prsrc=3> >> >> *Winner of the SD Times 100 2015 Award* >> <https://www.sencha.com/company/press/sencha-wins-2015-sd-times-100-award-in-user-experience-category/> >> >> -- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/420fadb6-e231-4765-a38a-1f545282ade6%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
