On Mon, May 9, 2016 at 12:52 PM, Jens <[email protected]> wrote:
> Hm ok, I think I got it. I would say my Arrays.sort() example should > actually use a critical check then because array.slice() can do lots > unexpected things (negative indexes for either argument works but results > an unexpected subset of array items to be sorted, toIndex can be larger > than fromIndex which basically results in no sorting at all) compared to > Java. A critical check would make sure that follow up code can expect the > array to be sorted they way its meant to be. > > That's fair; the way you described actually sounds like a good candidate for checkCritical. We already did similar with Arrays.copy to not end of with messed up indices. > I guess in some cases its just tough to draw the line. > > Yes, at the end it becomes a judgement call. > -- J. > > -- > You received this message because you are subscribed to the Google Groups > "GWT Contributors" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/google-web-toolkit-contributors/28e222a3-9138-447c-aeaa-a2daca59ccdd%40googlegroups.com > <https://groups.google.com/d/msgid/google-web-toolkit-contributors/28e222a3-9138-447c-aeaa-a2daca59ccdd%40googlegroups.com?utm_medium=email&utm_source=footer> > . > > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAN%3DyUA3__%2BRgr-42yXq9U-jPENMsMueOhvbwr1ugEMFefg4Ywg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
