I'm sure that it worked before. I'm also seeing some other issues where I am using JsInterop to interact with some generated HTML - but I am still investigating if that is due to changes in GWT or in our codebase.
I did not work on this project for about 8 weeks, so I have quite a backlog to go through. On Tue, 6 Sep 2016 at 19:28, 'Goktug Gokdogan' via GWT Contributors < google-web-toolkit-contributors@googlegroups.com> wrote: > It is surprising as Jens pointed out, we always qualified references with > $wnd until https://gwt-review.googlesource.com/#/c/15520/ (submitted 5 > weeks ago). So it shouldn't have worked earlier if you were not injecting > it to TOP_WINDOW. > If it worked earlier, then we unintentionally fixed a bug. Could you > double check if this was working before so we can see if there are some > other unintended behavior change introduced somewhere else? > > On Tue, Sep 6, 2016 at 2:43 AM, stuckagain <david.no...@gmail.com> wrote: > >> It was working fine before. >> >> Since it looks like JsInterop has changed recently (and it is still in >> beta) I will just update my code to either inject in the TOP_WINDOW or I >> try it with using window as namespace. >> >> >> On Monday, September 5, 2016 at 6:29:48 PM UTC+2, Jens wrote: >>> >>> Hm wondering how it ever worked for you as JsInterop usually qualifies >>> JS code with $wnd but your D3.js has been injected into the GWT iframe. So >>> AFAICT with JsInterop you would had to use TOP_WINDOW anyways. You can make >>> it work within the GWT iframe but then you can't use JsPackage.GLOBAL but >>> use a namespace that points to the iframe content window. >>> >>> Also see: >>> https://groups.google.com/d/msg/google-web-toolkit/GcsWUuzexvE/ApUg3sLZCQAJ >>> >>> So it looks like this behavior has changed? But yes you would need to >>> use "window" now to references the iframe's content window if you inject >>> the code into the iframe. >>> >>> -- J. >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "GWT Contributors" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/google-web-toolkit-contributors/7862784c-854a-4bb1-85c0-2b7734a984d3%40googlegroups.com >> <https://groups.google.com/d/msgid/google-web-toolkit-contributors/7862784c-854a-4bb1-85c0-2b7734a984d3%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> >> For more options, visit https://groups.google.com/d/optout. >> > > -- > You received this message because you are subscribed to the Google Groups > "GWT Contributors" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAN%3DyUA0RioQk7GatwdbkvwZKT6gKDEmB0daytVoKa9a%3DnGUd3A%40mail.gmail.com > <https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAN%3DyUA0RioQk7GatwdbkvwZKT6gKDEmB0daytVoKa9a%3DnGUd3A%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/CABrJHW3EG79VKA9Q9NpVBppwCO7j3XD05kzZAY%3DPPuCYV5z%2BXQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
