Yep, IMO the best compromise between solution & risk is to apply the patch over the last CUSTOM JDT build and wait for java9 lang support to upgrade to the last JDT.
On Mon, Oct 2, 2017 at 9:48 AM Thomas Broyer <[email protected]> wrote: > Note that this means GWT will effectively require JDK 8 for development > (gwt-servlet could possibly still work with 1.7, though at that point I'd > push for 1.8 too) > > https://www.eclipse.org/projects/project-plan.php?planurl=http://www.eclipse.org/eclipse/development/plans/eclipse_project_plan_4_8.xml#appendix > > > On Monday, October 2, 2017 at 8:42:22 AM UTC+2, Ignacio Baca Moreno-Torres > wrote: >> >> FYI The patch will be released for 4.8M3 >> https://bugs.eclipse.org/bugs/show_bug.cgi?id=521438#c17 >> >> On Wednesday, September 27, 2017 at 11:09:43 PM UTC+2, Roberto >> Lublinerman wrote: >>> >>> I would wait until an eclipse jdt release is done and upgrade JDT. >>> >>> On Tue, Sep 26, 2017 at 10:56 AM, Ignacio Baca Moreno-Torres < >>> [email protected]> wrote: >>> >>>> JDT has a bug (https://bugs.eclipse.org/bugs/show_bug.cgi?id=521438) >>>> that make it super slow to compile some project involving wildcards >>>> generics. Actually, there are many problems with performance and memory >>>> consumption since Java 8, this has just lived longer bc it was a bit more >>>> difficult but seem to be a combination of wildcard+inheritance that makes >>>> the internal type map to explode. RxJava 2 takes >3min to compile caused by >>>> this bug so it makes impossible to work with. >>>> >>>> The bug has been already solved. It needs to be merged and release in >>>> JDT and later on, it will be nice to be merged in the GWT JDT version as >>>> soon as possible, anyway as this seems to be a long process I have already >>>> released a patched version here. >>>> >>>> <repository> >>>> <id>rxjava-gwt-repo</id> >>>> >>>> <url>https://raw.githubusercontent.com/intendia-oss/rxjava-gwt/mvn-repo/</url> >>>> </repository> >>>> >>>> >>>> The patched commit is this one >>>> https://github.com/ibaca/eclipse.jdt.core/commit/995495659bddcaf193c0107f8489e698624ceea7 >>>> And applied in GWT here >>>> https://github.com/ibaca/gwt/commit/63218f3d695cfc6ec20fea776908b9801952f462 >>>> >>>> Do I create an issue in github? What do you think it is better, to just >>>> add the patch (as I have done) over the last version, or to upgrade to last >>>> JDT? >>>> >>>> PD: this will improve a bit compilation times and memory consumption ;). >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "GWT Contributors" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to >>>> [email protected]. >>>> To view this discussion on the web visit >>>> https://groups.google.com/d/msgid/google-web-toolkit-contributors/b564a261-a885-4c80-9125-eceb27d739a7%40googlegroups.com >>>> <https://groups.google.com/d/msgid/google-web-toolkit-contributors/b564a261-a885-4c80-9125-eceb27d739a7%40googlegroups.com?utm_medium=email&utm_source=footer> >>>> . >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> >>> -- > You received this message because you are subscribed to the Google Groups > "GWT Contributors" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/google-web-toolkit-contributors/8009d820-19ef-45dd-ba0d-8ba93bcf2e9b%40googlegroups.com > <https://groups.google.com/d/msgid/google-web-toolkit-contributors/8009d820-19ef-45dd-ba0d-8ba93bcf2e9b%40googlegroups.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/CABVWDC4oQqiNrSaZB_bPJ%3D7sk_vhONRGBO8122ZfC7Bojfxq4w%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
