The dependency issue could be solved separately in a much simpler change. I agree improvements could be made for 2.8 testing but it is a big project and I think it might be more worthwhile to have 3.x sooner.
Anyway we can discuss this further after we release the source. On Fri, Feb 16, 2018 at 12:09 PM Colin Alworth <[email protected]> wrote: > Several things I'd like to achieve: > * I'd like to support JUnit 4 in GWT2 (well, I'd actually like to support > JUnit 5 in both, but one step at a time) - JUnit 3 practically doesn't > exist outside of GWT2. > * There are probably better ways to do testing than the existing junit > shell wiring in GWT2, such as leveraging SDM to quickly make changes and > re-run tests, finding other ways to serve content, avoiding generators and > arcane servlet tags, etc. Adopting JUnit4 to replace the current generator > in GWT2 gets part of that work done up front. > * Existing junit shell wiring has some annoying dependencies and needs a > rewrite anyway if we are to continue migrating and updating official > modules - even if we decide that JUnit 3 is superior to 4, and that > recompiling without SDM is better in GWT2, we still can't (for example) > properly unit test an updated I18n module which uses a system property > named `locale` without running into issues with the existing I18n module, > which the old junit wiring makes every test use (JUnit -> Logging -> > LoggingDisabled -> UI, which includes basically everything else in > gwt-user). > > On Friday, February 16, 2018 at 1:59:12 PM UTC-6, Goktug Gokdogan wrote: >> >> I haven't thought about separating it from J2CL, not sure if it is a good >> idea. >> Why do you need it for GWT2? For code sharing, we simply use Junit3 style >> and we didn't feel much pain about it. >> >> >> On Thu, Feb 15, 2018 at 12:15 PM Colin Alworth <[email protected]> wrote: >> >>> Anything we can do to facilitate this? Also, if it is released under >>> j2cl, is there an expectation that it could be factored out and made to >>> work with GWT2, and released generally instead of just under J2CL (in its >>> binaries and its deadlines)? >>> >>> On Friday, January 26, 2018 at 9:17:39 PM UTC-6, Goktug Gokdogan wrote: >>>> >>>> Yes, that's correct. >>>> >>>> It is a simple system with two part generation. >>>> First part in bazel that generates an empty java class with a class >>>> annotation that points to JUnit suite to trigger APT. >>>> The second part in APT that generates the wrapper around junit3/junit4 >>>> tests that are listed in the suite to export test function to the global >>>> scope (as the javascript framework expects). >>>> >>>> There is no hybrid mode GwtTestcCase/JunitShell that tries to drive to >>>> compile or make things look like regular JVM test. End result is a pure >>>> javascript suite executed by a javascript test framework driver. >>>> >>>> On Fri, Jan 26, 2018 at 2:59 PM, Thomas Broyer <[email protected]> >>>> wrote: >>>> >>>>> Correct me if I'm wrong, this is relying on JUnit 4 suited to generate >>>>> appropriate goog.testing code, JUnit 3 test cases (GWTTestCase basically, >>>>> possibly simply TestCase), with a "new" emulation of those classes based >>>>> on >>>>> JsInterop to goog.testing, right? (goog.testing behaving similar to JUnit >>>>> 3 >>>>> to find test, setup, teardown methods/functions by naming rules) >>>>> >>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "GWT Contributors" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to >>>>> [email protected]. >>>>> To view this discussion on the web visit >>>>> https://groups.google.com/d/msgid/google-web-toolkit-contributors/a083c6c4-43aa-44f0-a639-2eab1a12a2c7%40googlegroups.com >>>>> . >>>>> For more options, visit https://groups.google.com/d/optout. >>>>> >>>> >>>> -- >>> You received this message because you are subscribed to the Google >>> Groups "GWT Contributors" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected] >>> . >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/google-web-toolkit-contributors/daeccad3-886f-4fda-801d-694c3d4f19d3%40googlegroups.com >>> <https://groups.google.com/d/msgid/google-web-toolkit-contributors/daeccad3-886f-4fda-801d-694c3d4f19d3%40googlegroups.com?utm_medium=email&utm_source=footer> >>> . >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- > You received this message because you are subscribed to the Google Groups > "GWT Contributors" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/google-web-toolkit-contributors/afe40d9c-a652-413c-a776-e2a6df9bba15%40googlegroups.com > <https://groups.google.com/d/msgid/google-web-toolkit-contributors/afe40d9c-a652-413c-a776-e2a6df9bba15%40googlegroups.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAN%3DyUA1w8YtZuRQVGYt2nuj4f-qmjG0S8Bcm3%3DXewzV_H%2BPTMg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
