Sorry for the late reply. In theory the process is: google modifies original cldr distribution per version, and gives a patch to us, then we run our generator and commit modified files. We don't run any python script, hence TimeZoneConstants.properties should have been always provided by google. I don't remember how that file in my commit was generated, apparently we should have some utility file for that, I have checked out to previous commit snapshot, patch cldr with goole patch, and run tools to generate files, though TimeZoneConstants.properties is not generated. It's so long ago that I don't conserve original tree with some program I could have utilised for that. CC-ed J.A. Tamplin, he might remember about if there was some parallel utility. I'll try to investigate further though
- Manolo On Sat, Dec 8, 2018 at 12:50 PM Ahmad Bawaneh <[email protected]> wrote: > I think in the GWT2 context we can just generate a new file with the same > old tool with updated data, but in the GWT3 context i think we need to > think of another approach. > few weeks ago i was working on a JodaTime emulation for GWT, one part of > that work was the generation of time zone info, i managed to build a tool > to generate them based on JodaTime runtime time zone info provider which > instead of creating run time instances i made the code emit source code and > it worked, i still think it could be made better by implementing a wrapper > instead of changing the code itself, anyway .. the time zones info in joda > time was based on iana database, and joda time is a will maintained and > regularly updated and reliable, so we can use that as a base for a > generator instead if inventing the whole wheel. > > in my approach i was generating a class per time zone which a factory > class to get a time zone by id, but if we still think that the JSON > constants is a better approach we still can generate the JSONs from those > files. > > this is just a thought that i had as i was working on emulating joda time. > > On Friday, December 7, 2018 at 5:17:20 PM UTC+2, Thomas Broyer wrote: >> >> We may want to generate that file using java.time.ZoneId then; WDYT? >> >> On Friday, December 7, 2018 at 3:55:50 PM UTC+1, Colin Alworth wrote: >>> >>> I messaged Manolo this morning after seeing this, and in gitter where >>> we're talking about this. >>> >>> From some digging in history, an old copy of the properties file >>> referenced pytz2011n, which looks like it might be a specific release of >>> pytz. The commit message Manolo made had a reference to some internal >>> Google python script, which I'm guessing takes that pytz library/database >>> (looks like they also just reference iana) and makes the .properties file, >>> and updates the interface that points at the file. >>> >>> The commits for previous changes went through google code and were >>> imported to git, so I'm not sure we can find much more public commentary. >>> >>> -- >>> Colin Alworth >>> [email protected] >>> >>> >>> >>> On Fri, Dec 7, 2018, at 8:32 AM, Thomas Broyer wrote: >>> >>> >>> >>> On Friday, December 7, 2018 at 1:54:09 PM UTC+1, Ahmad Bawaneh wrote: >>> >>> Anyone know what is generating TimeZoneConstants.properties, it says it >>> is generated from CLDR version 25 .. but i cant find any thing that >>> generates this gile in gwt code nor in gwt-tools code, was it generated >>> externally? >>> >>> >>> Have you tried pinging Manolo? He's the last one to have updated the >>> file, maybe he remembers the details. Either him or John Tamplin. >>> >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "GWT Contributors" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected] >>> . >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/google-web-toolkit-contributors/af65bf54-2dbb-4dc0-9833-1064e21b207a%40googlegroups.com >>> <https://groups.google.com/d/msgid/google-web-toolkit-contributors/af65bf54-2dbb-4dc0-9833-1064e21b207a%40googlegroups.com?utm_medium=email&utm_source=footer> >>> . >>> For more options, visit https://groups.google.com/d/optout. >>> >>> >>> -- > You received this message because you are subscribed to the Google Groups > "GWT Contributors" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/google-web-toolkit-contributors/e48d1ef7-5f72-4802-8ffa-9358e194f523%40googlegroups.com > <https://groups.google.com/d/msgid/google-web-toolkit-contributors/e48d1ef7-5f72-4802-8ffa-9358e194f523%40googlegroups.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAM28XAvAGJWnMP-CrdVRLcoYqtVncd5p%3DfqDoPg6hqHGoM8RvQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
