I actually added a pull/review request on gerrit at 3 Dec 2019

https://gwt-review.googlesource.com/q/I7af77f4b5e05c29a275c5b4a3f5610288f11dba9

but no signs of life so far. It certainly takes a lot of time to review...

    Vassilis


On Mon, Dec 2, 2019 at 1:38 PM Vassilis Virvilis <[email protected]> wrote:

> Here is the commit
> https://github.com/vasvir/gwt/commit/decf6974a284b24042c072e47662554ed0613a60
>
> Unfortunately GWT does not accept pull request on GitHub.
>
>
> On Thu, Nov 28, 2019 at 3:12 PM Vassilis Virvilis <[email protected]>
> wrote:
>
>> ok then.
>>
>> Here is the submitted issue https://github.com/gwtproject/gwt/issues/9675
>>
>> I will try to come with a patch in the next few days.
>>
>> Thanks
>>
>>   Vassilis
>>
>> On Thu, Nov 28, 2019 at 9:38 AM Jens <[email protected]> wrote:
>>
>>>
>>> Do you think a patch like that has any chance to be accepted? or this is
>>>> not considered to be an issue?
>>>>
>>>
>>> Seems like a valid behavior for JS libraries to check argument count, so
>>> I guess it should be accepted. Goktug or Roberto should probably review it.
>>>
>>> -- J.
>>>
>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "GWT Users" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to [email protected].
>>> To view this discussion on the web visit
>>> https://groups.google.com/d/msgid/google-web-toolkit/9232cdec-c84f-427a-a019-d0cef9262244%40googlegroups.com
>>> <https://groups.google.com/d/msgid/google-web-toolkit/9232cdec-c84f-427a-a019-d0cef9262244%40googlegroups.com?utm_medium=email&utm_source=footer>
>>> .
>>>
>>
>>
>> --
>> Vassilis Virvilis
>>
>
>
> --
> Vassilis Virvilis
>


-- 
Vassilis Virvilis

-- 
You received this message because you are subscribed to the Google Groups "GWT 
Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/google-web-toolkit/CAKbOjEzgxL0%2BCBZbZ9a_NQi4Eub1ptujwzYy0tRwx8zf0yGGWg%40mail.gmail.com.

Reply via email to