The change was rolled back due to FF production mode issues, but will be added back in the future when those issues are corrected.
However, since different browsers add different properties, I think iterating over the keys without checking hasOwnProperty is already broken. Also, JSONObject is essentially deprecated -- if you care about performance, you will write your own JavaScriptObject subclass and get zero overhead access to the JSON fields. On 11/17/09, Sripathi Krishnan <[email protected]> wrote: > Sending to the contributors mailing list.. > > --Sri > > > 2009/11/17 Matt Bishop <[email protected]> > >> I am referring to this recent checkin: >> >> >> http://code.google.com/p/google-web-toolkit/source/diff?spec=svn6936&r=6936&format=side&path=/releases/2.0/user/src/com/google/gwt/json/client/JSONObject.java >> >> The checkin comment states the change is needed for Chrome, but it is >> checked into the main JSONObject, not into a ChromeJSONObject. I >> would expect it to be in a Chrome class because: >> >> 1. It would keep the generated code for non-Chrome browsers smaller. >> 2. The change itself slows down non-Chrome browsers unnecessarily. >> >> JSONObject is a well-used object and it is important to keep it as >> small and fast is humanly possible. >> >> -- >> >> You received this message because you are subscribed to the Google Groups >> "Google Web Toolkit" group. >> To post to this group, send email to [email protected]. >> To unsubscribe from this group, send email to >> [email protected]<google-web-toolkit%[email protected]> >> . >> For more options, visit this group at >> http://groups.google.com/group/google-web-toolkit?hl=. >> >> >> > > -- > http://groups.google.com/group/Google-Web-Toolkit-Contributors -- John A. Tamplin Software Engineer (GWT), Google -- You received this message because you are subscribed to the Google Groups "Google Web Toolkit" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=.
