On Mar 13, 9:52 am, Thomas Broyer <[email protected]> wrote: > On Monday, March 12, 2012 10:40:06 PM UTC+1, Colin Eberhardt wrote: > > > > - Instead of wrapping everything in a UiBinder, I would have kept > > part > > > of the template in the HTML host page (I'd have wrapped only the <div > > > id=todoapp>, keeping the static instructions and credits sections in > > the > > > HTML host page) > > > I'm not so keen on this based on the goal of this project, to compare > > and contrast it with various JavaScript frameworks. Having the markup > > in a single place makes this comparison easier. > > On the other hand, people not knowing GWT could think it *cannot* simply > enhance an existing HTML layout, as the other implementations do. I see > TodoMVC as a way of "advertizing" toolkits/frameworks, and I fear people > see GWT as *only* being capable of building "empty window" interfaces > [http://bitworking.org/news/427/js-rest-and-empty-windows]
It is hard to second-guess the misconceptions a JavaScript developer may or may not have about GWT. It is such a different programming model. > > > - I wonder if you could have used a CompositeCell to split the "done > > > checkbox" and "delete button" handling in their own cells > > > I thought about that too, but one of the goals of the TodoMVC project > > is to use the same HTML markup and CSS for all the implementations. > > Mine already deviates due to CellList using divs rather than ul / li > > (it's a great shame this cannot be configured), so I wanted to adhere > > to the template as much as I could elsewhere. > > I don't see such a "goal" stated > inhttps://github.com/addyosmani/todomvc/wiki/Todo-Application-Specifica... > The stated goal is that the "look and feel" the same. > Also, there's nothing wrong not using ul / li provided you communicate the > role of elements by other means (ARIA). Maybe CellList should be enhanced > with ARIA for better accessibility, I haven't checked, but if that's the > case, it's an issue with GWT that I don't think the TodoMVC sample should > try to address (at least not at all cost). In trunk, CellTable now has a > Builder so I believe you could make one using <ul> as the container, <li> > for rows and <span> for cells. > Of course, YMMV. This is a stated goal of the project, albeit a recent one. When I submitted my GWT implementation there was a quite thorough code review, where deviations from the supplied HTML template were flagged and frowned upon! I totally agree that there is nothing wrong with an alternative markup - however, I wanted to be forgiving to the team that run the project and accommodating to their requests. As I mentioned, I will take your comments on board and appreciate the feedback. You are of course welcome to make changes and add pull requests for updates to this code, as is anyone else. Regards, Colin E. -- You received this message because you are subscribed to the Google Groups "Google Web Toolkit" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
