Hi all, FYI: gquery 1.2.0 has been released, it has the issue fixed.
About the advantages of using the closure compiler apart from the size of the js, I'll add the optimization of jsni blocks in your app, for instance I tend to embed 3party code (like cordova.js etc) in jsni blocks to optimize it. On Mon, Aug 27, 2012 at 11:56 PM, opn <[email protected]> wrote: > In my case the generated javascript is about 10% smaller now. Can't tell > exactly because I just made a quick test and the compileReport flag is > ignored with the closure compiler enabled. > > I read on g+ some time ago that some people had even better results (I > think up to 20% and more code size reduction? Can't find the post with the > comments anymore). > Am Montag, 27. August 2012 23:08:08 UTC+2 schrieb Deepak Singh: >> >> So what's benefit of this closure compiler ? >> >> On Tue, Aug 28, 2012 at 1:46 AM, Alex opn <[email protected]> wrote: >>> >>> Sorry for double post : ) Forgot to say that using the snapshot indeed >>> solved the problem. >>> >>> Am Montag, 27. August 2012 22:14:46 UTC+2 schrieb Alex opn: >>>> >>>> You can get it here: >>>> >>>> http://code.google.com/p/gwtquery/wiki/Downloads?tm=2 >>>> >>>> Direct Download: >>>> >>>> >>>> https://oss.sonatype.org/content/repositories/snapshots/com/googlecode/gwtquery/gwtquery/1.1.1-SNAPSHOT/gwtquery-1.1.1-20120724.210322-26.jar >>>> >>>> Maven users of the SNAPSHOT version you have to add these lines: >>>> >>>> <repositories> >>>> <repository> >>>> <id>sonatype-snapshots</id> >>>> >>>> <url>http://oss.sonatype.org/content/repositories/snapshots</url> >>>> >>>> <snapshots><enabled>true</enabled></snapshots> >>>> <releases><enabled>false</enabled></releases> >>>> >>>> </repository> >>>> <repositories> >>>> >>>> <dependencies> >>>> <dependency> >>>> <groupId>com.googlecode.gwtquery</groupId> >>>> >>>> <artifactId>gwtquery</artifactId> >>>> <version>1.1.1-SNAPSHOT</version> >>>> >>>> <scope>provided</scope> >>>> </dependency> >>>> </dependencies> >>>> >>>> >>>> >>>> Am Montag, 27. August 2012 20:52:45 UTC+2 schrieb Deepak Singh: >>>>> >>>>> Can i also have the new Gwtquery-snapshot to avoid this error ? >>>>> >>>>> On Mon, Aug 27, 2012 at 9:23 PM, Alex opn <[email protected]> wrote: >>>>>> >>>>>> Thanks for pointing this out! Google didn't come up with the issue. >>>>>> Trying with the new GQuery-Snapshot now. >>>>>> >>>>>> Am Montag, 27. August 2012 17:32:03 UTC+2 schrieb Thomas Broyer: >>>>>>> >>>>>>> >>>>>>> >>>>>>> On Monday, August 27, 2012 4:13:24 PM UTC+2, Alex opn wrote: >>>>>>>> >>>>>>>> After reading this I thought I'd give it a try, too and got the same >>>>>>>> error: >>>>>>>> >>>>>>>> [ERROR] Unexpected internal compiler error >>>>>>>> [INFO] java.lang.IllegalStateException: Expected non-empty >>>>>>>> string. Reference node STRING >>>>>>>> >>>>>>>> Any hints? : ) >>>>>>> >>>>>>> >>>>>>> See http://code.google.com/p/google-web-toolkit/issues/detail?id=7469 >>>>>>> The issue seems to only happen if you have a switch/case in JSNI with >>>>>>> an empty string as a 'case' value (see >>>>>>> http://code.google.com/p/gwtquery/source/detail?r=1035) >>>>>> >>>>>> -- >>>>>> You received this message because you are subscribed to the Google >>>>>> Groups "Google Web Toolkit" group. >>>>>> To view this discussion on the web visit >>>>>> https://groups.google.com/d/msg/google-web-toolkit/-/oDSZBHOG6_EJ. >>>>>> >>>>>> To post to this group, send email to [email protected]. >>>>>> To unsubscribe from this group, send email to >>>>>> [email protected]. >>>>>> For more options, visit this group at >>>>>> http://groups.google.com/group/google-web-toolkit?hl=en. >>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Deepak Singh >>> >>> -- >>> You received this message because you are subscribed to the Google Groups >>> "gwtquery" group. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msg/gwtquery/-/aNRPR-97yCcJ. >>> >>> To post to this group, send email to [email protected]. >>> To unsubscribe from this group, send email to >>> [email protected]. >>> >>> For more options, visit this group at >>> http://groups.google.com/group/gwtquery?hl=en. >> >> >> >> >> -- >> Deepak Singh > > -- > You received this message because you are subscribed to the Google Groups > "gwtquery" group. > To view this discussion on the web visit > https://groups.google.com/d/msg/gwtquery/-/-It2Bo0eUacJ. > > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/gwtquery?hl=en. -- You received this message because you are subscribed to the Google Groups "Google Web Toolkit" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
