Hey, thanks for your feedback!
'gwt.codesvr' is only filtered. Other query-string parameters should not be altered. However I've decided to add the query-string to the historyToken. It turned out that this is a bad idea because then "place" is not the same place as "place?some=foo". This may cause the effect of removing the complete query string. "http://gwt-pushstate-examples.appspot.com/!homePage?foo=bar"; The place "!homePage?foo=bar" is not found and the user get's redirected to "http://gwt-pushstate-examples.appspot.com/!homePage"; I'm going to fix that soon. BTW: If you have changes I would appreciate it if you push the changes back. Cheers, Johannes Am 12.12.2012 um 13:07 schrieb ChrisK: > Great work! > > As far as I can see it will remove query parameters when using pushState? I > may extend it to support passing through all query parameters rather than > just "gwt.codesvr". > > > On Wednesday, 21 November 2012 17:17:25 UTC, Johannes Barop wrote: > Hello GWT community, > > I've just released gwt-pushstate. It implements HTML5 pushState with GWTs > standard History API and should work with existing applications fairly well. > It also makes sure that the development mode doesn't break and provides a > transparent fallback for non-pushState browsers. It's open source (Apache2) > and uploaded to the Maven central repository. You can find the source here: > https://github.com/jbarop/gwt-pushstate > > A running sample application is uploaded here: > http://gwt-pushstate-examples.appspot.com > The sample is basicly GWTP-0.7's gwtp-sample-hplace with little modifications > to add the pushState support: > https://github.com/jbarop/gwt-pushstate/commit/a3d278b2fae71adc4ea7fb22c5eb121ada36b644 > > > > Any feedback heavily appreciated. > Johannes > > > -- > You received this message because you are subscribed to the Google Groups > "Google Web Toolkit" group. > To view this discussion on the web visit > https://groups.google.com/d/msg/google-web-toolkit/-/34cywFthT2YJ. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/google-web-toolkit?hl=en. -- You received this message because you are subscribed to the Google Groups "Google Web Toolkit" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
