Chris, Could we sign up for this: https://reviews.apache.org/groups/ ?
This could help us for code review. Reading diff file is not good for large changes like the one Alexis just made. - Henry On Fri, Jul 22, 2011 at 4:30 PM, Mattmann, Chris A (388J) <chris.a.mattm...@jpl.nasa.gov> wrote: > No need to revert. Thanks for your email > Alexis and for your explanation. If there are > tests and improvement and docs to be made, > and folks have the cycles, and energy to do so, > please move forward and do it. > > Thanks to both you and to Julien for contributions > to the Cassandra back end. > > Cheers, > Chris > > On Jul 22, 2011, at 4:08 PM, Alexis wrote: > >> Hi, >> >> Sorry I have committed my changes before I had the go ahead of the >> other peers. I am still learning the opensource etiquette. I thought >> it was fine to replace the code since I believe the Cassandra part was >> broken. I personnally never managed to use the code "as is". It was >> mentioned to me the entire backend needed to be rewritten: >> See Julien's comment in this page: >> http://techvineyard.blogspot.com/2011/01/trying-nutch-20-hbase-storage.html: >> >> "The Cassandra backend in GORA is in need of serious work and is not >> considered fully functional, IIRC it is not thread safe. There has >> been a new release of Cassandra in the meantime and I am pretty sure >> that it would be quicker to simply write a new backend for GORA based >> on the latest release..." >> >> Now we have 2 options: >> - revert the modifications and go back to a broken state >> - test the new version and iterate from there. I'm sure it's not >> perfect but at least we have a seemingly working state to start with. >> >> Sorry for the bad surprise. >> >> On Fri, Jul 22, 2011 at 8:21 AM, Chris A. Mattmann (JIRA) >> <j...@apache.org> wrote: >>> >>> [ >>> https://issues.apache.org/jira/browse/GORA-22?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069581#comment-13069581 >>> ] >>> >>> Chris A. Mattmann commented on GORA-22: >>> --------------------------------------- >>> >>> One note though: Alexis, it seems like you've replaced and/or added upon >>> somehow to the cassandra backend. It was my impression we had one already >>> or that it was functioning/etc. What does your patch do that improves or >>> adds to it? Would be great to explain for the benefit of others watching. >>> >>>> Upgrade cassandra backend to cassandra 0.7 >>>> ------------------------------------------ >>>> >>>> Key: GORA-22 >>>> URL: https://issues.apache.org/jira/browse/GORA-22 >>>> Project: Gora >>>> Issue Type: Improvement >>>> Components: storage >>>> Affects Versions: 0.2-incubating >>>> Reporter: Julien Nioche >>>> Fix For: 0.2-incubating >>>> >>>> Attachments: gora-cassandra-mapping.xml, >>>> gora-cassandra-mapping.xml, gora.patch, goraCassandra.patch >>>> >>>> >>> >>> >>> -- >>> This message is automatically generated by JIRA. >>> For more information on JIRA, see: http://www.atlassian.com/software/jira >>> >>> >>> > > > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > Chris Mattmann, Ph.D. > Senior Computer Scientist > NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA > Office: 171-266B, Mailstop: 171-246 > Email: chris.a.mattm...@nasa.gov > WWW: http://sunset.usc.edu/~mattmann/ > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > Adjunct Assistant Professor, Computer Science Department > University of Southern California, Los Angeles, CA 90089 USA > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > >
