Hi Enis, .gitignore files have now been added back into SVN area. Apologies for taking so long to get this reverted.
Committed @ r1227267 in trunk Thanks Lewis On Thu, Dec 15, 2011 at 12:26 PM, Lewis John Mcgibbney <[email protected]> wrote: > OK so to clarify. > > I've removed the extra jar files which were littering the place. I've > also removed the .gitignore files whereever I saw them. I'll revert > the .gitignore files for the reasons you mention as they are more than > justified Enis. > > Thanks > > Lewis > > On Wed, Dec 14, 2011 at 8:01 PM, Enis Söztutar <[email protected]> wrote: >> Thanks Lewis for taking care of this. I agree that we should remove the >> extra jars, and cleanup the unnecessary files. The only thing is that, >> since we should continue supporting the git repo, when you check out the >> code from git://git.apache.org/gora.gitthat we should be able to compile >> and run the unit tests. >> >> We may opt to keep the .gitignore (and similar) files in the repo, but not >> release them in the tarball, but it is too much of a hassle to maintain >> this. Besides I think of .gitignore files as a part of the code (since it >> configures your build structure), so we can release them together with the >> code in the tarball. >> >> Thanks. >> Enis >> >> On Tue, Dec 13, 2011 at 3:22 AM, Lewis John Mcgibbney < >> [email protected]> wrote: >> >>> Hi Enis, >>> >>> No I'm not using Git, but realise that a few of you were/are, >>> therefore I am more than happy for you to revert the changes I made to >>> suit those Git repos users. >>> >>> If there is anything else I can do then please say and I will help to >>> make the necessary changes. >>> >>> Thanks >>> >>> On Mon, Dec 12, 2011 at 10:56 PM, Enis Söztutar <[email protected]> >>> wrote: >>> > Hi, >>> > >>> > I think we should keep the .gitignore files, and revert the commit for >>> > this. The git/svn flame wars is still very hot in members@, but even if >>> we >>> > will not have read/write git access, we will always have at least >>> read-only >>> > git access at git.apache.org. Some people (like me) prefer to use git as >>> > their main tool, and we have a git repo at >>> > git://git.apache.org/gora.gitthat we should support. Besides, the >>> > release CAN and SHOULD include the >>> > .gitignore files for git to work correctly. >>> > >>> > Normally, we do not need more than the top level .gitignore, but since >>> for >>> > the build to work with ant, we needed those empty dirs at >>> > (gora-xxx/lib-ext, etc), and since git does not track empty dirs, the >>> > default way to add them to repo is to add an empty .gitignore. Now that >>> we >>> > have switched to maven, we probably do not need some of those dirs, so I >>> > propose to revert the commit, and selectively do remove the ones not >>> > needed. One more reason to revert the change is that the patch for issue >>> > GORA-63 seems to be accidentally committed at >>> > gora-core/src/main/java/org/apache/gora/compiler/GoraCompiler.java. >>> > >>> > Lewis, are you using the git repo. If not, I can do the changes if you >>> > prefer. >>> > >>> > Thanks, >>> > Enis >>> > >>> > On Sun, Dec 11, 2011 at 1:01 PM, Lewis John Mcgibbney < >>> > [email protected]> wrote: >>> > >>> >> Hi, >>> >> >>> >> You should be able to see this has now been addressed and Committed @ >>> >> revision 1213062 in trunk. >>> >> >>> >> Thanks >>> >> >>> >> Lewis >>> >> >>> >> On Thu, Dec 8, 2011 at 10:16 PM, Lewis John Mcgibbney >>> >> <[email protected]> wrote: >>> >> > OK please see below >>> >> >> >>> >> >> >>> >> >> Yeah we can remove the .gitnore files, feel free to svn remove them, >>> +1. >>> >> > >>> >> > will do >>> >> > >>> >> >> >>> >> >> >>> >> >> I'd like to move away from having any of these files in trunk since >>> we >>> >> >> don't >>> >> >> need them as they are all available on Central right? Let's get rid >>> of >>> >> >> them... >>> >> > >>> >> > Yeah, we've moved completely away from the cassandra and hector >>> versions >>> >> and >>> >> > now support 1.X, in addition this thrift jar looks pretty our of >>> place as >>> >> > I've upgraded the HBase dependency to 0.90.4 (latest stable as well). >>> >> > >>> >> > I'll look into it and get a Jira logged and patch submitted. >>> >> > >>> >> > ta >>> >> > >>> >> >> >>> >> >> >>> >> >> Cheers, >>> >> >> Chris >>> >> >> >>> >> > Thanks >>> >> > Lewis >>> >> > >>> >> > >>> >> > -- >>> >> > Lewis >>> >> > >>> >> >>> >> >>> >> >>> >> -- >>> >> Lewis >>> >> >>> >>> >>> >>> -- >>> Lewis >>> > > > > -- > Lewis -- Lewis
