On Wed, Oct 28, 2015 at 6:05 PM, Ehsan Akhgari <[email protected]> wrote:
> On 2015-10-28 4:26 PM, Olivier Yiptong wrote: > >> The non-Firefox part of this module proposal lives outside of Firefox and >> would be updated out-of-band from Firefox. >> > > The location of the source code is not the important issue, IMO. So far > at least the Firefox module has covered all user-facing aspects of the > browser, and the new tab page is no different. Where it is hosted and how > it's implemented should not affect what module governs it. > This is not true. Many user-facing pieces of the browser are owned by the Toolkit module for example. Even then pieces of the UI are owned by yet other modules, like the add-ons discovery page in the add-ons manager which is owned by the AMO module. Hello is another example of a standalone module for a piece of the UI. > You can document the knowledge of the proposed owners and peers by adding > them as Firefox peers focusing on specific parts of the browser code. I > think for all intents and purposes the end result is the same for you. For > example, I'm a Firefox peer, but I usually only review private browsing > specific code. > > If you think a new module is really warranted here, you should probably > get dcamp's green light since this is really breaking an existing part of a > module into a new module. Also as I mentioned before, as a pure matter of > technicality, if you want to create a new module you should figure out how > you'd do that with Firefox not having submodules. The new module would > need a home. :-) > I'll speak for dcamp and say that since the main pieces of this code live outside the tree that the Firefox peers generally work in then it would make some sense to have a standalone module for it. Happy for Firefox to still own the pieces that live in Firefox if that makes sense. Mostly though as you say whichever route we take it shouldn't stop work getting done. Honestly with the scale we're operating at now I'm not entirely sure out current module system makes sense anymore but that's a different discussion. _______________________________________________ governance mailing list [email protected] https://lists.mozilla.org/listinfo/governance
