I have no specific knowledge of the Rust coding conventions, but unless there is something truly egregious about them, I agree with Henri we should adhere to whatever they are, provided they are in fact well-defined.
-Ekr On Tue, Apr 26, 2016 at 7:40 AM, Henri Sivonen <[email protected]> wrote: > On Wed, Mar 9, 2016 at 11:20 PM, Nathan Froyd <[email protected]> wrote: > > - formatting/naming style (The C++ bits of > > > https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style > > , essentially) > ... > > The Rust community also > > has somewhat more established guidelines around style as well. > > Can we, please, please decide not to fight the Rust team's and Rust > community's style choices and write Rust code in Gecko to look like > normal Rust code even if this makes Rust code in Gecko differ from C++ > code in Gecko? That is, no aFoo or mFoo but unprefixed_snake_case and > formatting code in general like rustfmt does it by default. By not > fighting the conventions of the language, we'll have a better chance > of leveraging tools (starting with built-in compiler checks for > snake_case!) and getting people who want to write Rust code to > contribute to the Rust parts of Gecko. > > I'm OK with style owners who agree with the above. :-) > > (FWIW, I think it would be fine for snake_case to spill over to C++ > code in Gecko, but I care more about keeping at least Rust code > looking like normal Rust code.) > -- > Henri Sivonen > [email protected] > https://hsivonen.fi/ > _______________________________________________ > governance mailing list > [email protected] > https://lists.mozilla.org/listinfo/governance > _______________________________________________ governance mailing list [email protected] https://lists.mozilla.org/listinfo/governance
