On Wed, Jan 24, 2018 at 8:30 AM, L. David Baron <dba...@dbaron.org> wrote: > This looks good to me; I think you should go ahead and add this. > (And I say this as someone who used to be pretty involved in a lot > of this code, but is probably now detached enough from it that I > shouldn't generally review it.) > > Two comments: > > * I think the entry should be clear in the Bugzilla components line > that it's only a small part of "CSS Parsing and Computation".
Fixed. > * I wonder if it should say "animation-related and > interpolation-related" instead of just "animation-related" Fixed. > I also wonder if some of the SMIL code should be in this module > rather than the SVG module? I discussed this with Daniel Holbert who is the only other person familiar with SMIL code and we agreed that at this stage it still seems to belong in the SVG module. I've gone ahead and added this information to the module page now.[1] Best regards, Brian [1] https://wiki.mozilla.org/index.php?title=Modules/Core&diff=prev&oldid=1187558 _______________________________________________ governance mailing list governance@lists.mozilla.org https://lists.mozilla.org/listinfo/governance
