On Fri, Mar 23, 2018 at 01:38:49PM +0300, Alexey Kryukov wrote: > Hi, > > I've noticed there is currently no capture-preview support for CHDK, > although some stubs are present in the code. Of course, remote capture > without live view isn't that useful. So here's a patch, which also > updates chdk_live_view.h to the recent version. It supports either > jpeg (needs libjpeg) or ppm output. > > Key issue with CHDK live view is that it usually produces a more or less > distorted picture with a wrong aspect ratio (typically 3:2 instead of > 4:3). That's due to an internally used representation with "non-square" > pixels, so it seems impossible to do anything with it without > involving a scaling algorithm. Still it is better than nothing.
I applied it as-is for now, but it has a small bug at least. + header->version_major = dtoh32a(&data[off]); + header->version_minor = dtoh32a(&data[off+=4]); Here data[off] is used twice. Ciao, Marcus ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Gphoto-devel mailing list Gphoto-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/gphoto-devel
