https://bugs.gpodder.org/show_bug.cgi?id=1097

--- Comment #5 from Vladimir Voroshilov <[email protected]> 2010-08-21 
08:19:45 BST ---
(In reply to comment #4)
> (In reply to comment #3)
> > If i start gPodder 'as is' it uses utf8 for  filenames and folders (both
> > downloaded episodes and synced filenames). Thus a have to start gPodder with
> > "set LANG=ru_RU.cp1251" in batch file.
> 
> Do you think we can add code to gPodder that can detect the "LANG" variable
> based on some Windows registry setting or something?

Quick google'ing didn't show me any reliable methods. 

Om my machine i find tiny solution (patch below) instead of setting LANG
variable.
Unfortunately i tested it only with  "filesystem sync" under win64 and
can't say what will happen under other OS/locales.  

And i want to point again: setting LANG was only the part of the solution.
There is something wrong with unicode strings (and therefore "isunicode"
routine) inside gPodder code. As far as i can understood python does not treat
some of the strings passed to sanitize_filename as unicode.

Here is tiny patch: 

diff --git a/lib/site-packages/gpodder/util.py
b/lib/site-packages/gpodder/util.py
index 320afd8..5232f4a 100644
--- a/lib/site-packages/gpodder/util.py
+++ b/lib/site-packages/gpodder/util.py
@@ -68,7 +68,8 @@ N_ = gpodder.ngettext
 if gpodder.ui.maemo:
     encoding = 'utf8'
 else:
-    encoding = 'iso-8859-15'
+    import sys
+    encoding = sys.getfilesystemencoding()

 if 'LANG' in os.environ and '.' in os.environ['LANG']:
     lang = os.environ['LANG']

-- 
Configure bugmail: https://bugs.gpodder.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
gPodder-Bugs mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/gpodder-bugs

Reply via email to