https://bugs.gpodder.org/show_bug.cgi?id=1136
Summary: NULL value in "total" column (with non-null playmark)
breaks API
Product: gpodder.net
Version: unspecified
Platform: PC
OS/Version: Linux
Status: NEW
Severity: major
Priority: low
Component: Advanced API (Server-side)
AssignedTo: [email protected]
ReportedBy: [email protected]
Created an attachment (id=562)
--> (https://bugs.gpodder.org/attachment.cgi?id=562)
Patch in the live instance that works around this issue for now
I've managed to inject NULL values for the "total" column with a broken client
(during development, so it is unlikely to happen with users using released
versions of gPodder). You can see the result in the database using:
select * from episode_log where total is null and playmark is not null;
This breaks the episode actions download. As we (I think) agreed that playmark
uploads without total time is possible, I now wonder if this is a bug in the
specification (must not be allowed), in the uploading code (must not accept and
give an error instead) or in the downloading (must not return the faulty
action).
I've worked around this issue in the live instance now by applying the attached
patch. Please review it and revert it on the server side if you think that it
should be fixed at some other place.
Does this also warrant a fix in the mygpoclient library? It depends on the
specification - if the creation of a playback action event with position, but
without total is invalid, we could block is directly in the library (we would
of course still have to fix this issue on the server side as well, as not all
clients have to use the mygpoclient library).
--
Configure bugmail: https://bugs.gpodder.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
gPodder-Bugs mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/gpodder-bugs
