https://bugs.gpodder.org/show_bug.cgi?id=1263
--- Comment #1 from Thomas Perl <[email protected]> 2011-01-13 15:13:34 GMT --- Finally had time to review the patch. Some feedback: - Please avoid introducing a new dependency on "kaa" - Do not refer to the GUI code (import message) from libconverter (because your code should work in CLI mode and in a different UI as well) - Please remove all "print" statements - use liblogger if you really need to - Write a decoder script and use it instead of "oggdec" - Move the MP3 encoding command to the add_converter call (so you can have a different one for your mp4 decoder) - The same is true for the output filename extension - make this a parameter as well (mp3 for the ogg converter, mpg for yours) - The deviceWidth commands and stuff like that should be moved to your converter script and not placed into libconverters.py If you need more help, just ask me on IRC. -- Configure bugmail: https://bugs.gpodder.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes. _______________________________________________ gPodder-Bugs mailing list [email protected] https://lists.berlios.de/mailman/listinfo/gpodder-bugs
